Re: [PATCH] watchdog: orion_wdt: Use devm APIs for clock and watchdog management

[kernel test robot]

Hi Rosen,

kernel test robot noticed the following build warnings:

[auto build test WARNING on groeck-staging/hwmon]
[also build test WARNING on groeck-staging/hwmon-next groeck-staging/watchdog groeck-staging/watchdog-next linus/master v7.1-rc4 next-20260519]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Rosen-Penev/watchdog-orion_wdt-Use-devm-APIs-for-clock-and-watchdog-management/20260520-054408
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon
patch link:    https://lore.kernel.org/r/20260519214229.16656-1-rosenp%40gmail.com
patch subject: [PATCH] watchdog: orion_wdt: Use devm APIs for clock and watchdog management
config: arm-dove_defconfig (https://download.01.org/0day-ci/archive/20260520/202605201246.gIDxpcj6-lkp@xxxxxxxxx/config)
compiler: arm-linux-gnueabi-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260520/202605201246.gIDxpcj6-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605201246.gIDxpcj6-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

   drivers/watchdog/orion_wdt.c: In function 'orion_wdt_clock_init':
>> drivers/watchdog/orion_wdt.c:82:13: warning: unused variable 'ret' [-Wunused-variable]
      82 |         int ret;
         |             ^~~
   drivers/watchdog/orion_wdt.c: In function 'armada370_wdt_clock_init':
   drivers/watchdog/orion_wdt.c:95:13: warning: unused variable 'ret' [-Wunused-variable]
      95 |         int ret;
         |             ^~~
   drivers/watchdog/orion_wdt.c: In function 'armada375_wdt_clock_init':
   drivers/watchdog/orion_wdt.c:113:13: warning: unused variable 'ret' [-Wunused-variable]
     113 |         int ret;
         |             ^~~
   drivers/watchdog/orion_wdt.c: In function 'armadaxp_wdt_clock_init':
   drivers/watchdog/orion_wdt.c:144:13: warning: unused variable 'ret' [-Wunused-variable]
     144 |         int ret;
         |             ^~~


vim +/ret +82 drivers/watchdog/orion_wdt.c

22ac92322c83334 drivers/watchdog/orion5x_wdt.c Sylver Bruneau  2008-06-26  78  
1924227bcda1d18 drivers/watchdog/orion_wdt.c   Ezequiel Garcia 2014-02-10  79  static int orion_wdt_clock_init(struct platform_device *pdev,
1924227bcda1d18 drivers/watchdog/orion_wdt.c   Ezequiel Garcia 2014-02-10  80  				struct orion_watchdog *dev)
df6707b21904950 drivers/watchdog/orion5x_wdt.c Thomas Reitmayr 2009-02-20  81  {
1924227bcda1d18 drivers/watchdog/orion_wdt.c   Ezequiel Garcia 2014-02-10 @82  	int ret;
df6707b21904950 drivers/watchdog/orion5x_wdt.c Thomas Reitmayr 2009-02-20  83  
df5a672cef35a9e drivers/watchdog/orion_wdt.c   Rosen Penev     2026-05-19  84  	dev->clk = devm_clk_get_enabled(&pdev->dev, NULL);
1924227bcda1d18 drivers/watchdog/orion_wdt.c   Ezequiel Garcia 2014-02-10  85  	if (IS_ERR(dev->clk))
1924227bcda1d18 drivers/watchdog/orion_wdt.c   Ezequiel Garcia 2014-02-10  86  		return PTR_ERR(dev->clk);
df6707b21904950 drivers/watchdog/orion5x_wdt.c Thomas Reitmayr 2009-02-20  87  
463f96e0cdacce5 drivers/watchdog/orion_wdt.c   Ezequiel Garcia 2014-02-10  88  	dev->clk_rate = clk_get_rate(dev->clk);
0dd6e4847ed8a42 drivers/watchdog/orion_wdt.c   Axel Lin        2012-03-26  89  	return 0;
df6707b21904950 drivers/watchdog/orion5x_wdt.c Thomas Reitmayr 2009-02-20  90  }
df6707b21904950 drivers/watchdog/orion5x_wdt.c Thomas Reitmayr 2009-02-20  91  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki