Re: [PATCH v2 2/2] dt-bindings: usb: richtek,rt1711h: add missing 'port' property

[Akash Sukhavasi]

On Tue, May 19, 2026 at 3:08 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On Mon, May 18, 2026 at 11:20:14AM -0500, Akash Sukhavasi wrote:
> > The schema declares 'additionalProperties: false' but omits the
> > top-level 'port' property, which hi3660-hikey960.dts uses to
> > describe the role-switch graph endpoint. This causes dtbs_check
> > to emit:
> >
> >   hi3660-hikey960.dtb: rt1711h@4e (richtek,rt1711h): 'port' does
> >   not match any of the regexes: '^pinctrl-[0-9]+$'
> >
> > Add the missing property using /schemas/graph.yaml#/properties/port,
> > following the pattern used by realtek,rts5411.yaml and other USB
> > controller bindings.
> >
> > Update the example accordingly.
> >
> > Signed-off-by: Akash Sukhavasi <akash.sukhavasi@xxxxxxxxx>
> > ---
> >  .../devicetree/bindings/usb/richtek,rt1711h.yaml    | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
> > index 7ded36384..05ffc33a2 100644
> > --- a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
> > +++ b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
> > @@ -52,6 +52,13 @@ properties:
> >      description:
> >        Properties for usb c connector.
> >
> > +  port:
> > +    $ref: /schemas/graph.yaml#/properties/port
> > +    description:
> > +      OF graph port describing the connection to the USB role switch
> > +      consumer (e.g., a dwc3 controller with usb-role-switch), used to
> > +      convey type-C data-role changes signaled by the TCPC.
>
> I don't think this is right. There is no such data link for "role
> switch", so this should be part of standard connector ports.
>
> And the only other binding (I found) having these two is
> qcom,pmic-typec, which in practice only uses connector in all of DTS
> files.

Hi Krzysztof,

Makes sense. I'll take a look at hi3660-hikey960.dts itself since it
also has the port@0 required property warning on the same node. Will
send a separate patch.

Dropping patch 2/2 from this series.

Can patch 1/2 (.txt removal) be applied independently with your Reviewed-by?

Thanks,
Akash