[PATCH] staging: greybus: uart: document locking and fix indentation
From: AkaLuiz
Date: Tue May 19 2026 - 22:44:10 EST
Add comments describing what the lock fields in struct gb_tty
protect, and fix the indentation of the
wait_for_completion_timeout() call.
Signed-off-by: AkaLuiz <luizcarlosmdea@xxxxxxxxx>
---
drivers/staging/greybus/uart.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index 7d060b4cd33d..85586e9a4341 100644
--- a/drivers/staging/greybus/uart.c
+++ b/drivers/staging/greybus/uart.c
@@ -50,12 +50,12 @@ struct gb_tty {
unsigned int minor;
unsigned char clocal;
bool disconnected;
- spinlock_t read_lock;
- spinlock_t write_lock;
+ spinlock_t read_lock; /* protects iocount and oldcount for TIOCMIWAIT */
+ spinlock_t write_lock; /* protects write_fifo and credits */
struct async_icount iocount;
struct async_icount oldcount;
wait_queue_head_t wioctl;
- struct mutex mutex;
+ struct mutex mutex; /* protects disconnected during lookup and removal */
u8 ctrlin; /* input control lines */
u8 ctrlout; /* output control lines */
struct gb_uart_set_line_coding_request line_coding;
@@ -318,7 +318,7 @@ static int gb_uart_wait_for_all_credits(struct gb_tty *gb_tty)
return 0;
ret = wait_for_completion_timeout(&gb_tty->credits_complete,
- msecs_to_jiffies(GB_UART_CREDIT_WAIT_TIMEOUT_MSEC));
+ msecs_to_jiffies(GB_UART_CREDIT_WAIT_TIMEOUT_MSEC));
if (!ret) {
dev_err(&gb_tty->gbphy_dev->dev,
"time out waiting for credits\n");
--
2.54.0