Re: [PATCH] hwmon: (coretemp) Replace sprintf() with sysfs_emit() for sysfs show functions
From: Dongyang Jin
Date: Tue May 19 2026 - 22:30:39 EST
You are absolutely right, and I apologize for the noise.
I misunderstood the scope of acceptable cleanups for legacy drivers. I will stop sending such patches and focus only on functional fixes or updates for drivers that specifically require them.
Thank you for your time.
Best regards,
Dongyang Jin
On 2026/5/19 23:16, Guenter Roeck wrote:
On 5/18/26 23:52, Dongyang Jin wrote:
Replace sprintf() with sysfs_emit() in sysfs show functions. sysfs_emit()
is preferred for formatting sysfs output because it provides safer bounds
checking. No functional changes.
Signed-off-by: Dongyang Jin <jindongyang@xxxxxxxxxx>
I consider this a nuisance patch. Nothing is gained from it.
Can people please stop sending such patches ? It gets annoying,
and I don't have an endless amount of time to review it all.
If you make a functional change or fix bugs, cleanups are welcome.
Otherwise, I'll barely accept bare cleanup patches for drivers
using the with_info API. Otherwise please leave old drivers alone.
Thanks,
Guenter