Re: [PATCH net-next] mlxsw: spectrum_ethtool: expose per-PG rx_discards

[Keno Fischer]

On Mon, May 18, 2026 at 1:33 PM Petr Machata <petrm@xxxxxxxxxx> wrote:
> Keno Fischer <keno@xxxxxxxxxxxx> writes:
> >
> > Of note, from emperical testing, these counter are per-"priority group"
> > (PG) not per-"switch priority". It's a bit confusing, because the rest
> > of these counter are per-"switch priority" and the header file calls
> > these "Per Priority Group Counters". However, that should be read as
> > "(Per Priority) Group Counters", not "Per (Priority Group) Counters".
>
> I think it's (Per-Priority Group) Counters. As in group of counters that
> are per priority. Similarly there's the "Ethernet Discard Counter Group
> Counters". These names come from the HW manual.

Yes, that's what I meant, sorry if that wasn't clear.
I meant to make the distinction that this comment
is correct for all other counters (even if marginally
misleading), but not quite this one, since it is
Per-Priority-Group, not Per-Priority (i.e. if you
map 3:2, you will get the prio_3 counters,
but the rx_discards_pg2 counters).
I think we're on the same page, just spelling it out for the record.

> LGTM, thanks!
> Reviewed-by: Petr Machata <petrm@xxxxxxxxxx>

Thanks!