Re: [PATCH] irqchip/dw-apb-ictl: fix compilation on x86

[Rosen Penev]

On Tue, May 19, 2026 at 10:16 AM Thomas Gleixner <tglx@xxxxxxxxxx> wrote:
>
> On Mon, May 18 2026 at 19:57, Rosen Penev wrote:
> > __irq_entry belongs nowhere in irqchip drivers as it is an
> > architecture specific annotation. There's no specific architecture
> > depends for DW_APB_ICTL and there probably shouldn't be.
>
> Care to see how that driver is selected? Certainly not by x86.
make LLVM=1 ARCH=i386 allmodconfig
make LLVM=1 ARCH=i386 -j 31
>
> > Fixes:
> >
> > drivers/irqchip/irq-dw-apb-ictl.c:33:13: error: variable has incomplete type 'void'
> >    33 | static void __irq_entry dw_apb_ictl_handle_irq(struct pt_regs *regs)
>
> That's fixing nothing because the driver cannot be built on x86 and the
> architectures which select it have a reason to move the handler into the
> irqentry.text section via __irq_entry.
>
> I'm slowly getting fed up by the AI slob which ends up in my inbox every
> other day.
This was not detected by AI. Note the lack of an assisted-by tag.
>
> Thanks,
>
>         tglx
>
>
>