Re: [PATCH] nfsd: drain backchannel callbacks before freeing a session

From: Jeff Layton

Date: Tue May 19 2026 - 16:02:10 EST


On Tue, 2026-05-19 at 10:49 -0700, Chris Mason wrote:
> DESTROY_SESSION can free an nfsd4_session while a backchannel callback
> for the same client is still live on rpciod, leaving clp->cl_cb_session
> as a dangling pointer.
>
> The first patch waits on cl_cb_inflight, and the second hopes to make
> things harder to regress in the future by dropping a NULL in there.
>
> Signed-off-by: Chris Mason <clm@xxxxxxxx>

Assuming you want to reverse the order, you can add this:

Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>

The other review comment from Claude sounds reasonable too, but harder
to hit in practice.