Re: [PATCH v7] media: pci: add AVMatrix HWS capture driver

[Ben Hoff]

Hi Hans,

Good catch.

I've created a new patch here that dropped these three functions, see
it here: https://patchwork.linuxtv.org/project/linux-media/patch/20260519161218.79385-1-hoff.benjamin.k@xxxxxxxxx/

On Tue, May 19, 2026 at 9:00 AM <hverkuil+cisco@xxxxxxxxxx> wrote:
>
> Hi Ben,
>
> On 11/05/2026 01:50, Ben Hoff wrote:
>
> <snip>
>
> While looking for something else, I stumbled on this:
>
> > diff --git a/drivers/media/pci/hws/hws_v4l2_ioctl.h b/drivers/media/pci/hws/hws_v4l2_ioctl.h
> > new file mode 100644
> > index 000000000000..53044f78d6fa
> > --- /dev/null
> > +++ b/drivers/media/pci/hws/hws_v4l2_ioctl.h
> > @@ -0,0 +1,36 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +#ifndef HWS_V4L2_IOCTL_H
> > +#define HWS_V4L2_IOCTL_H
> > +
> > +#include <media/v4l2-ctrls.h>
> > +#include <linux/fs.h>
> > +
> > +extern const struct v4l2_ctrl_ops hws_ctrl_ops;
> > +
> > +int hws_vidioc_querycap(struct file *file, void *priv, struct v4l2_capability *cap);
> > +int hws_vidioc_enum_fmt_vid_cap(struct file *file, void *priv_fh, struct v4l2_fmtdesc *f);
> > +int hws_vidioc_g_fmt_vid_cap(struct file *file, void *fh, struct v4l2_format *fmt);
> > +int hws_vidioc_try_fmt_vid_cap(struct file *file, void *fh, struct v4l2_format *f);
> > +int hws_vidioc_g_std(struct file *file, void *priv, v4l2_std_id *tvnorms);
> > +int hws_vidioc_s_std(struct file *file, void *priv, v4l2_std_id tvnorms);
> > +int hws_vidioc_g_parm(struct file *file, void *fh, struct v4l2_streamparm *setfps);
> > +int hws_vidioc_enum_input(struct file *file, void *priv, struct v4l2_input *i);
> > +int hws_vidioc_g_input(struct file *file, void *priv, unsigned int *i);
> > +int hws_vidioc_s_input(struct file *file, void *priv, unsigned int i);
> > +int hws_vidioc_g_ctrl(struct file *file, void *fh, struct v4l2_control *a);
> > +int hws_vidioc_s_ctrl(struct file *file, void *fh, struct v4l2_control *a);
>
> These two functions are unused.
>
> > +int hws_vidioc_dv_timings_cap(struct file *file, void *fh,
> > +                           struct v4l2_dv_timings_cap *cap);
> > +int hws_vidioc_s_dv_timings(struct file *file, void *fh,
> > +                         struct v4l2_dv_timings *timings);
> > +
> > +int hws_vidioc_queryctrl(struct file *file, void *fh, struct v4l2_queryctrl *a);
>
> Ditto for this one.
>
> > +int hws_vidioc_g_dv_timings(struct file *file, void *fh,
> > +                         struct v4l2_dv_timings *timings);
> > +int hws_vidioc_enum_dv_timings(struct file *file, void *fh,
> > +                            struct v4l2_enum_dv_timings *edv);
> > +int hws_vidioc_query_dv_timings(struct file *file, void *fh,
> > +                             struct v4l2_dv_timings *timings);
> > +int hws_vidioc_s_fmt_vid_cap(struct file *file, void *priv, struct v4l2_format *f);
> > +
> > +#endif
>
> Can you make a follow-up patch to drop these?
>
> Regards,
>
>         Hans