Re: [PATCH] spi: aspeed: Replace VLA parameter with flat pointer in calibration helper

From: David Laight

Date: Tue May 19 2026 - 13:14:10 EST


On Tue, 19 May 2026 12:03:51 +0100
Mark Brown <broonie@xxxxxxxxxx> wrote:

> On Mon, May 18, 2026 at 05:57:08PM +0800, Chin-Ting Kuo wrote:
>
> > - while (k < cols && buf[i][k])
> > + while (k < cols && buf[i * cols + k])
>
> This really needs () to make it clear what's going on; the precedence is
> well defined but not everyone is going to know that off the top of their
> head.

Come on, it's multiply and add - everyone is going to get that right.

-- David