Re: [PATCH RESEND] media: i2c: isl7998x: inline i2c_check_functionality check
From: Thorsten Blum
Date: Tue May 19 2026 - 10:47:59 EST
On Tue, May 19, 2026 at 04:23:56PM +0200, Michael Tretter wrote:
> On Sun, 17 May 2026 19:20:35 +0200, Thorsten Blum wrote:
> > Inline the i2c_check_functionality() check, since the function returns a
> > boolean status rather than an error code.
>
> Actually, i2c_check_functionality() returns the boolean result of the
> comparison as an int. It's better to treat it like a boolean, though.
>
> >
> > Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
>
> Reviewed-by: Michael Tretter <m.tretter@xxxxxxxxxxxxxx>
Thank you for your review.
I sent a patch [1] to change i2c_check_functionality() to bool, but
Wolfram asked to change the int call sites first.
[1] https://lore.kernel.org/lkml/20260421161607.61314-3-thorsten.blum@xxxxxxxxx/