Re: [PATCH 1/3] mmc: renesas_sdhi: Apply bad taps quirk to RZ/G2H

[Lad, Prabhakar]

Hi Geert,

Thank you for the review.

On Mon, May 18, 2026 at 2:07 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Thu, 14 May 2026 at 23:20, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Apply the sdhi_quirks_bad_taps2367 quirk to the RZ/G2H (R8A774E1)
> > SoC.
> >
> > RZ/G2H is identical to the R-Car H3-N (R8A77951), which already uses
> > this quirk to avoid unreliable tuning tap positions. Use the same
> > quirk entry for RZ/G2H to ensure consistent SDHI tuning behaviour.
> >
> > Fixes: 31941342888d ("arm64: dts: renesas: r8a774e1: Add SDHI nodes")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> > +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> > @@ -224,6 +224,7 @@ static const struct renesas_sdhi_quirks sdhi_quirks_rzg2l = {
> >   */
> >  static const struct soc_device_attribute sdhi_quirks_match[]  = {
>
> This array is meant for quirks, i.e. to address issues on specific
> SoC variants that cannot just be identified by the compatible value.
>
Ok, I will drop it from the quirks list.

> >         { .soc_id = "r8a774a1", .revision = "ES1.[012]", .data = &sdhi_quirks_4tap_nohs400 },
> > +       { .soc_id = "r8a774e1", .data = &sdhi_quirks_bad_taps2367 },
>
> Hence I think this should be RZ/G2H should be added to
> renesas_sdhi_internal_dmac_of_match[] instead, referring to
> of_r8a7795_compatible.
>
Ok I will add an entry in  renesas_sdhi_internal_dmac_of_match[] (same
for patches 2 and 3).

Cheers,
Prabhakar