Re: [PATCH v2 3/4] drm/imagination: Rename FW booted to FW initialised

[Javier Martinez Canillas]

Brajesh Gupta <brajesh.gupta@xxxxxxxxxx> writes:

Hello Brajesh and Matt,

> Rename the variable from 'booted' to 'initialised' to align with the
> driver's expectations and state, indicating that FW boot initialisation
> is complete and the firmware is fully initialised.
>
> Signed-off-by: Brajesh Gupta <brajesh.gupta@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/imagination/pvr_device.c |  2 +-
>  drivers/gpu/drm/imagination/pvr_fw.c     |  4 ++--
>  drivers/gpu/drm/imagination/pvr_fw.h     |  7 +++++--
>  drivers/gpu/drm/imagination/pvr_mmu.c    |  4 ++--
>  drivers/gpu/drm/imagination/pvr_power.c  | 14 +++++++-------
>  5 files changed, 17 insertions(+), 14 deletions(-)
>

[...]

> -	if (pvr_dev->fw_dev.booted) {
> -		err = pvr_power_fw_disable(pvr_dev, false, true);
> +	if (pvr_dev->fw_dev.initialised) {
> +		err = pvr_power_fw_disable(pvr_dev, false);
>  		if (err)

This broke the build because it incorrectly changed the pvr_power_fw_disable()
and pvr_power_fw_enable() function calls, dropping the third argument.

I've just posted a patch to fix this.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat