Re: [PATCH 0/2] iommu/arm-smmu: Use FIELD_MODIFY() for bitfield operations

[Hans Zhang]

On 5/19/26 18:51, Will Deacon wrote:
> On Fri, May 01, 2026 at 12:45:43AM +0800, Hans Zhang wrote:
> > Replace open-coded bitfield modifications with the standard FIELD_MODIFY()
> > macro. This improves code readability and adds type/range checking without
> > functional changes.
>
> Does it _really_ improve the readability? '&=' and '|=' patterns are
> pretty idiomatic C code, if you ask me.
>
> > FIELD_MODIFY() internally performs the same mask-clear + set operation but
> > eliminates repetitive boilerplate.
> >
> > ---
> > Hi, If the Maintainers think it's not necessary, please ignore it.
>
> I don't really mind the code either way, so I think I'd prefer to leave
> it as-is unless somebody wants to convince me otherwise...
>
> Will

Hi Will,

It's not like that. Please take a look at the accepted patch below.



https://lore.kernel.org/linux-pci/20260505165436.GA737933@bhelgaas/

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=42ec65b46a4fc7565d48daa42bf025fdc67800eb

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=5fd6f2154734f447e83b6de9a08d16848605191e


Best regards,
Hans