Re: [PATCH net v2 1/2] net: phy: honor eee_disabled_modes in phy_support_eee()

[Andrew Lunn]

On Tue, May 19, 2026 at 08:20:02AM +0200, Nicolai Buchwitz wrote:
> Hi Andrew,
> 
> Thanks for your review.
> 
> On 19.5.2026 04:19, Andrew Lunn wrote:
> > On Mon, May 18, 2026 at 10:23:09AM +0200, Nicolai Buchwitz wrote:
> > > phy_support_eee() copies supported_eee into advertising_eee
> > > unconditionally, overwriting any filtering applied during phy_probe()
> > > based on DT eee-broken-* properties or driver-populated
> > > eee_disabled_modes.
> > 
> > Sorry, i should of questioned this on v1. What PHY are you using which
> > masks advertising_eee in probe? It seems like this is wrong, and it
> > should be setting >eee_disabled_modes, or maybe eee_supported.c
> 
> The masking isn't PHY-specific. phy_probe() applies eee_disabled_modes
> to advertising_eee after of_set_phy_eee_broken() picks up the
> eee-broken-* properties from the PHY DT node.

Ah, O.K, i understood that wrongly. But you do say phy_probe(), not
PHY probe(), so it was my error.

	Andrew