Re: [PATCH v3 phy-next 2/2] phy: ti: add PHY driver for TI DS125DF111 Dual-Channel Retimer

[Vinod Koul]

On 18-05-26, 10:29, Ioana Ciornei wrote:
> On Sun, May 17, 2026 at 10:07:56PM +0530, Vinod Koul wrote:
> > On 16-05-26, 09:03, Ioana Ciornei wrote:
> > > Add a generic PHY driver for the TI DS125DF111 Multi-Protocol
> > > Dual-Channel Retimer. The driver currently supports only 10G and 1G link
> > > speeds but it can easily extended to also cover other usecases.
> > > 
> > > Since the available datasheet (https://www.ti.com/lit/gpn/DS125DF111)
> > > does not name the registers, the name for the macros were determined by
> > > their usage pattern.
> > > 
> > > A PHY device is created for each of the two channels present on the
> > > retimer. This allows for independent configuration of the two channels.
> > > This capability is especially important on retimers which have more than
> > > 2 channels that can be, depending on the board design, connected in
> > > multiple different ways to the SerDes lanes.
> > > 
> > > Signed-off-by: Ioana Ciornei <ioana.ciornei@xxxxxxx>
> > > ---
> > > Changes in v3:
> > > - Use reverse Christmas tree ordering
> > > - Print a symbolic description in case of error
> > > - Some words do not need to be capitalized
> > > - Remove duplicated exit code path
> > > - Return -EINVAL in case of unsupported submode received in .set_mode()
> > > - Add a .validate() callback
> > > - Remove comma after sentinel entry
> > > - Add a ds125df111_rmw() helper
> > > - Use read_poll_timeout() to wait for channel reset to complete
> > > 
> > > Changes in v2:
> > > - Explicitly include all the needed headers
> > > - Change ds125df111_xlate() so that it returns an error if args_count is
> > > not exactly 1
> > > - Add a MAINTAINERS entry
> > > ---
> > >  MAINTAINERS                     |   7 +
> > >  drivers/phy/ti/Kconfig          |  10 ++
> > >  drivers/phy/ti/Makefile         |   1 +
> > >  drivers/phy/ti/phy-ds125df111.c | 294 ++++++++++++++++++++++++++++++++
> > >  4 files changed, 312 insertions(+)
> > >  create mode 100644 drivers/phy/ti/phy-ds125df111.c
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index f877e5aaf2c7..58f410b666e7 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -26781,6 +26781,13 @@ T:	git git://linuxtv.org/mhadli/v4l-dvb-davinci_devices.git
> > >  F:	drivers/media/platform/ti/davinci/
> > >  F:	include/media/davinci/
> > >  
> > > +TI DS125DF111 RETIMER PHY DRIVER
> > > +M:	Ioana Ciornei <ioana.ciornei@xxxxxxx>
> > > +L:	linux-phy@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers)
> > > +S:	Maintained
> > > +F:	Documentation/devicetree/bindings/phy/ti,ds125df111.yaml
> > > +F:	drivers/phy/ti/phy-ds125df111.c
> > > +
> > >  TI ENHANCED CAPTURE (eCAP) DRIVER
> > >  M:	Vignesh Raghavendra <vigneshr@xxxxxx>
> > >  R:	Julien Panis <jpanis@xxxxxxxxxxxx>
> > > diff --git a/drivers/phy/ti/Kconfig b/drivers/phy/ti/Kconfig
> > > index b40f28019131..475e80fcd52d 100644
> > > --- a/drivers/phy/ti/Kconfig
> > > +++ b/drivers/phy/ti/Kconfig
> > > @@ -111,3 +111,13 @@ config PHY_TI_GMII_SEL
> > >  	help
> > >  	  This driver supports configuring of the TI CPSW Port mode depending on
> > >  	  the Ethernet PHY connected to the CPSW Port.
> > > +
> > > +config PHY_TI_DS125DF111
> > 
> > This should be in alphabetical order, so I guess before PHY_TI_G...
> 
> Now that I actually tried to make the change that you requested, I
> realised that the Kconfig is not following any alphabetical order. And
> neither does the Makefile.
> 
> Do you still want me to move the entries?

Yes please. I will sort this one later in the cycle again!

-- 
~Vinod