Re: [PATCH 1/4] dt-bindings: firmware: qcom,scm: Add minidump SRAM property
From: Mukesh Ojha
Date: Tue May 19 2026 - 05:43:46 EST
On Tue, May 19, 2026 at 02:12:27PM +0530, Mukesh Ojha wrote:
> On Fri, May 08, 2026 at 07:07:14AM -0500, Rob Herring wrote:
> > On Thu, May 7, 2026 at 3:07 AM Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx> wrote:
> > >
> > > On most Qualcomm SoCs where minidump is supported, a word in always-on
> > > SRAM is shared between the kernel and boot firmware. Before DDR is
> > > initialised on the warm reset following a crash, firmware reads this
> > > word to decide if minidump is enabled and collect a minidump and where
> > > to deliver it (USB upload to a host, or save to local storage).
> > >
> > > Add 'sram' and 'sram-names' properties to the SCM binding to describe
> > > a region in always-on SRAM where the minidump download destination
> > > value could be written. Boot firmware reads it before DDR is initialised
> > > on a warm reset to decide where to store the minidump either to host
> > > PC or to on device storage.
> > >
> > > Most of the Qualcomm SoC supporting minidump supports this, added the
> > > kaanapali SoC for now.
> > >
> > > Suggested-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> > > Signed-off-by: Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx>
> > > ---
> > > .../bindings/firmware/qcom,scm.yaml | 57 +++++++++++++++++++
> > > 1 file changed, 57 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> > > index 7918d31f58b4..6813081fd74a 100644
> > > --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> > > +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> > > @@ -127,6 +127,22 @@ properties:
> > > - description: offset of the download mode control register
> > > description: TCSR hardware block
> > >
> > > + sram:
> > > + $ref: /schemas/types.yaml#/definitions/phandle-array
> >
> > Drop. This is a common property though we need to create a common definition.
>
> Did you mean to just drop ref for now? And common definition could be followed later or
> create one as part of the series.
Ah !! I see your change
https://lore.kernel.org/all/20260511165942.2774868-1-robh@xxxxxxxxxx/
merged., so no need for a new definition.
--
-Mukesh Ojha