Re: [PATCH v2 1/3] dt-bindings: crypto: qcom,ice: Add sa8255p support

[Geert Uytterhoeven]

Hi Krzysztof,

On Tue, 19 May 2026 at 09:37, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> On 19/05/2026 09:30, Geert Uytterhoeven wrote:
> > On Thu, 14 May 2026 at 14:56, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> >> On Mon, May 11, 2026 at 08:37:48PM -0700, Linlin Zhang wrote:
> >>> On sa8255p, resources such as PHY, clocks, regulators, and resets are
> >>> managed by remote firmware via the SCMI power protocol. As a result, the
> >>> ICE driver cannot directly access clocks and must instead use power-domains
> >>> to request resource configuration.
> >>
> >> Then how can it be compatible with qcom,inline-crypto-engine?
> >
> > It is a pity there are such big differences between the SoC-integration
> > "hardware" description in DT of systems with and without SCMI.
> >
> > For R-Car X5H, we proposed a difference approach[1].
> > Linlin: do you think this would be a viable solution for your platform?
>
> In the cover letter I see:
>
> "This means Linux can no longer perform various system operations (e.g.
> clock, power domain, and reset control)"

"... by accessing the hardware directly."

> I skimmed through the rest including bindings, and I do not see how you
> did it differently. Patchset is mixing multiple subsystems and topics,
> so it does not make easier to find what you meant.

The gist is in:
  clk: renesas: Add R-Car X5H CPG SCMI remapping driver
  pmdomain: renesas: Add R-Car X5H MDLC SCMI remapping driver

FTR, this is what we discussed in Tokyo last December.

> Can you point me directly how did you do it differently? And by "it" I
> mean what you comment here - "such big differences between ... "?

1. Describe the actual hardware in DT (+ a firmware property linking
   to SCMI)
   For sa8255p, that would be a clock controller device node.
2. Write Linux drivers that do not access the hardware directly, but map
   operation to whatever mechanism the SCMI firmware does provide.
   For sa8255p, that would be a clock driver that translates clock
   enable/disable to power domain on/off.

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds