Re: [PATCH v4 09/10] dt-bindings: firmware: add arm,ras-cper

[Ahmed Tiba]

On 19/05/2026 08:04, Krzysztof Kozlowski wrote:
> On 18/05/2026 13:57, Ahmed Tiba wrote:
> > Describe the DeviceTree node that exposes the Arm firmware-first
> > CPER provider and hook the file into MAINTAINERS so the
> > binding has an owner.
> >
> > Signed-off-by: Ahmed Tiba <ahmed.tiba@xxxxxxx>
>
> Please implement previous comments.

Could you please clarify which previous DT comments you still see
as unaddressed?

My understanding was that I had addressed the earlier points on the YAML
description formatting, the `memory-region` description text, and the
example. If I missed a specific item beyond the one below, please point 
me to it.

> > ---
> >   .../devicetree/bindings/firmware/arm,ras-cper.yaml | 71 ++++++++++++++++++++++
> >   MAINTAINERS                                        |  5 ++
> >   2 files changed, 76 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/firmware/arm,ras-cper.yaml b/Documentation/devicetree/bindings/firmware/arm,ras-cper.yaml
> > new file mode 100644
> > index 000000000000..81dc37390af5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/firmware/arm,ras-cper.yaml
> > @@ -0,0 +1,71 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/firmware/arm,ras-cper.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Arm RAS CPER provider
> > +
> > +maintainers:
> > +  - Ahmed Tiba <ahmed.tiba@xxxxxxx>
> > +
> > +description:
> > +  Arm Reliability, Availability and Serviceability (RAS) firmware can expose
> > +  a firmware-first CPER error source directly via DeviceTree. Firmware
> > +  provides the CPER Generic Error Status block and notifies the OS through
> > +  an interrupt.
> > +
> > +properties:
> > +  compatible:
> > +    const: arm,ras-cper
> > +
> > +  memory-region:
> > +    oneOf:
> > +      - items:
> > +          - description:
> > +              CPER Generic Error Status block exposed by firmware
> > +      - items:
> > +          - description:
> > +              CPER Generic Error Status block exposed by firmware.
>
> Also, this is just a list with minItems. No need for oneOf.
Understood, I will drop the oneOf and use a plain list with minItems


Best regards,
Ahmed