Re: [PATCH net v2 1/2] net: phy: honor eee_disabled_modes in phy_support_eee()

[Andrew Lunn]

On Mon, May 18, 2026 at 10:23:09AM +0200, Nicolai Buchwitz wrote:
> phy_support_eee() copies supported_eee into advertising_eee
> unconditionally, overwriting any filtering applied during phy_probe()
> based on DT eee-broken-* properties or driver-populated
> eee_disabled_modes.

Sorry, i should of questioned this on v1. What PHY are you using which
masks advertising_eee in probe? It seems like this is wrong, and it
should be setting >eee_disabled_modes, or maybe eee_supported.

> Fixes: 49168d1980e2 ("net: phy: Add phy_support_eee() indicating MAC support EEE")
> Signed-off-by: Nicolai Buchwitz <nb@xxxxxxxxxxx>

This patch itself looks O.K.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew