Re: [PATCH] mm/page_alloc: drop a misleading __always_inline

From: SeongJae Park

Date: Mon May 18 2026 - 21:35:07 EST


On Sun, 17 May 2026 23:37:05 +0000 Brendan Jackman <jackmanb@xxxxxxxxxx> wrote:

> get_pfnblock_migratetype() is called from outside page_alloc.c, so it
> cannot always be inlined. Remove the annotation to avoid misleading
> readers.

Makes sense.

>
> At least in my minimal config, with GCC, this doesn't change
> mm/page_alloc.o at all.

Same on my setup.

>
> Suggested-by: Vlastimil Babka <vbabka@xxxxxxxxxx>
> Link: https://lore.kernel.org/all/016c8bef-57ef-44ef-bf60-86dbfd368dcd@xxxxxxxxxx/
> Signed-off-by: Brendan Jackman <jackmanb@xxxxxxxxxx>

Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>


Thanks,
SJ

[...]