Re: [PATCH 1/6] mm/damon: fix missing parens in macro arguments
From: SeongJae Park
Date: Mon May 18 2026 - 20:10:28 EST
On Mon, 18 May 2026 22:09:27 +0300 Maksym Shcherba <mshcherba2000@xxxxxxxxx> wrote:
> The DAMON iterator macros do not wrap their pointer arguments with
> parentheses. This can cause build failures when the argument is a
> complex expression due to operator precedence issues.
>
> Add missing parentheses around the arguments in the following macros
> to prevent potential build failures:
> - damon_for_each_region()
> - damon_for_each_region_from()
> - damon_for_each_region_safe()
> - damos_for_each_quota_goal()
Nice catch, thank you!
>
> Assisted-by: Antigravity:Gemini-3.1-Pro
> Signed-off-by: Maksym Shcherba <maksym.shcherba@xxxxxxxxxx>
checkpatch.pl warns as below:
WARNING: From:/Signed-off-by: email address mismatch: 'From: Maksym Shcherba <mshcherba2000@xxxxxxxxx>' != 'Signed-off-by: Maksym Shcherba <maksym.shcherba@xxxxxxxxxx>'
Assuming that will be fixed,
Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>
Thanks,
SJ
[...]