Re: [PATCH v9 02/23] x86/virt/tdx: Move TDX_FEATURES0 bits to asm/tdx.h
From: Edgecombe, Rick P
Date: Mon May 18 2026 - 12:58:33 EST
On Mon, 2026-05-18 at 15:52 +0800, Chao Gao wrote:
> On Fri, May 15, 2026 at 09:15:47AM -0700, Dave Hansen wrote:
> > On 5/13/26 08:09, Chao Gao wrote:
> > > This prepares for TDX module update [1] and Dynamic PAMT [2] support. Both
> > > add new TDX_FEATURES0 capability bits, and both need those capabilities to
> > > be queried from code outside arch/x86/virt. The corresponding feature-query
> > > helpers therefore need to live in the public asm/tdx.h header, so move the
> > > existing bit definitions there first.
> >
> > Please don't add unnecessary changelog cruft. If you need this move for
> > this series, that's enough.
>
> Sure. Will remove "Dynamic PAMT" stuff from the changelog.
I think it should not link to old versions of this series to explain the
preparation. That is very confusing. We can just explain what will come in the
later patches of *this* series. I'll circle back and propose some verbiage.