Re: [PATCH v22 07/13] power: reset: Add psci-reboot-mode driver

[Shivendra Pratap]

On 18-05-2026 14:28, Bartosz Golaszewski wrote:
> On Thu, 14 May 2026 16:25:48 +0200, Shivendra Pratap
> <shivendra.pratap@xxxxxxxxxxxxxxxx> said:
> > PSCI supports different types of resets like SYSTEM_RESET, SYSTEM_RESET2
> > ARCH WARM reset and SYSTEM_RESET2 vendor-specific resets. Currently
> > there is no common driver that handles all supported psci resets at one
> > place. Additionally, there is no common mechanism to issue the supported
> > psci resets from userspace.
> >
> > Add a psci-reboot-mode driver, and define two types of PSCI resets,
> > predefined-resets and vendor-specific resets. Predefined-resets are
> > defined by psci driver and vendor-specific resets are defined by SoC
> > vendors, under the psci:reboot-mode node of SoC device tree.
> >
> > Register the driver with the reboot-mode framework to interface these
> > resets to userspace. When userspace initiates a supported command, pass
> > the reset arguments to the PSCI driver to enable command-based reset.
> >
> > This change allows userspace to issue supported PSCI reset commands
> > using the standard reboot system calls while enabling SoC vendors to
> > define their specific resets for PSCI.
> >
> > Signed-off-by: Shivendra Pratap <shivendra.pratap@xxxxxxxxxxxxxxxx>
> > ---
> >   MAINTAINERS                            |  1 +
> >   drivers/power/reset/Kconfig            | 10 +++++
> >   drivers/power/reset/Makefile           |  1 +
> >   drivers/power/reset/psci-reboot-mode.c | 72 ++++++++++++++++++++++++++++++++++
> >   4 files changed, 84 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 36ba42209c0b332813a296880cd55798a5592d2a..4b0815c31679550f5ab719de4a5852990c7cc643 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -21342,6 +21342,7 @@ S:	Maintained
> >   F:	Documentation/devicetree/bindings/arm/psci.yaml
> >   F:	drivers/firmware/psci/
> >   F:	drivers/mfd/psci-mfd.c
> > +F:	drivers/power/reset/psci-reboot-mode.c
> >   F:	include/linux/psci.h
> >   F:	include/uapi/linux/psci.h
> >
> > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> > index 124afb99febe92450b6ae322aeed3b63fa2070df..d9d1f768b8691abc3b32f2675519f2ddbaf19b84 100644
> > --- a/drivers/power/reset/Kconfig
> > +++ b/drivers/power/reset/Kconfig
> > @@ -348,6 +348,16 @@ config NVMEM_REBOOT_MODE
> >   	  then the bootloader can read it and take different
> >   	  action according to the mode.
> >
> > +config PSCI_REBOOT_MODE
> > +	bool "PSCI reboot mode driver"
> > +	depends on OF && ARM_PSCI_FW
>
> Can you add COMPILE_TEST coverage here too please?

Ack. thanks.

> > +	select REBOOT_MODE
> > +	help
> > +	  Say y here will enable PSCI reboot mode driver. This gets
> > +	  the PSCI reboot mode arguments and passes them to psci
> > +	  driver. psci driver uses these arguments for issuing
> > +	  device reset into different boot states.
> > +
> >   config POWER_MLXBF
> >   	tristate "Mellanox BlueField power handling driver"
> >   	depends on (GPIO_MLXBF2 || GPIO_MLXBF3) && ACPI
[SNIP..]

> > +static struct platform_driver psci_reboot_mode_driver = {
> > +	.probe  = psci_reboot_mode_probe,
> > +	.driver = {
> > +		.name	= "psci-reboot-mode",
> > +	},
> > +};
> > +
>
> You can drop the newline here.

Ack.

thanks,
Shivendra