Re: [PATCH v2 1/2] dt-bindings: Add bindings for StarFive JHB100 SoC trng controller

[Conor Dooley]

On Mon, May 18, 2026 at 02:52:42PM +0800, lianfeng.ouyang wrote:
> From: Lianfeng Ouyang <lianfeng.ouyang@xxxxxxxxxxxxxxxx>
> 
> jh8100 is no longer supported
> Jia Jie Ho has resigned

Please put some effort into your commit messages. Look around on LKML,
where do you ever seen commit messages as perfunctory as this?
Please speak to the other developers at Starfive about what the commit
messages should look like.

The first "sentence" here isn't even really accurate, is it?
The jh8100 was never even released to customers, right?

pw-bot: changes-requested

Thanks,
Conor.

> 
> Signed-off-by: Lianfeng Ouyang <lianfeng.ouyang@xxxxxxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/rng/starfive,jh7110-trng.yaml  | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> index 4639247e9e51..d21769b7d54e 100644
> --- a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> +++ b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> @@ -7,15 +7,13 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>  title: StarFive SoC TRNG Module
> 
>  maintainers:
> -  - Jia Jie Ho <jiajie.ho@xxxxxxxxxxxxxxxx>
> +  - Lianfeng Ouyang <lianfeng.ouyang@xxxxxxxxxxxxxxxx>
> 
>  properties:
>    compatible:
> -    oneOf:
> -      - items:
> -          - const: starfive,jh8100-trng
> -          - const: starfive,jh7110-trng
> -      - const: starfive,jh7110-trng
> +    enum:
> +      - starfive,jh7110-trng
> +      - starfive,jhb100-trng
> 
>    reg:
>      maxItems: 1
> --
> 2.43.0
> 
>

Attachment: signature.asc
Description: PGP signature