Re: [PATCH v2 1/2] spi: qcom-geni: trace: Add trace events for Qualcomm GENI SPI

[Praveen Talari]

Hi Mark,

On 18-05-2026 19:37, Mark Brown wrote:
> On Tue, May 12, 2026 at 11:42:52AM +0530, Praveen Talari wrote:
>
> > +TRACE_EVENT(geni_spi_fifo_params,
> > +	    TP_PROTO(struct device *dev, u8 cs, u32 mode,
> > +		     u32 mode_changed, bool cs_changed),
> > +	    TP_ARGS(dev, cs, mode, mode_changed, cs_changed),
> > +
> > +	    TP_STRUCT__entry(__string(name, dev_name(dev))
> > +			     __field(u8, cs)
> > +			     __field(u32, mode)
> > +			     __field(u32, mode_changed)
> > +			     __field(bool, cs_changed)
> These don't really seem like FIFO parameters?  I see that's the name of
> the function where we log this but they're more just generic bus status
> things.
I agree with you.

Can i use below name or any suggestions?

+TRACE_EVENT(geni_spi_setup_params

Thanks,

Praveen Talari