Re: [PATCH v3 02/10] iio: accel: mma8452: switch to non-devm request_threaded_irq()

[Jonathan Cameron]

On Wed, 6 May 2026 18:47:49 +0100
Jonathan Cameron <jic23@xxxxxxxxxx> wrote:

> On Tue,  5 May 2026 23:16:32 +0530
> Sanjay Chitroda <sanjayembeddedse@xxxxxxxxx> wrote:
> 
> > From: Sanjay Chitroda <sanjayembeddedse@xxxxxxxxx>
> > 
> > Avoid using devm_request_threaded_irq() as the driver requires explicit
> > error-handling path(s). Using devm_* API together with goto-based
> > unwinding breaks the expected LIFO resource release model.
> > 
> > Add explicit IRQ cleanup in the driver teardown paths to follow kernel
> > resource management conventions.
> > 
> > Fixes: 28e3427824cc ("iio: mma8452: Basic support for transient events.")  
> For a fixes tag we need to have an explicit issue rather than
> it not following best practice.  Patch itself is correct, and if all
> else is good and you don't have a specific ordering problem in mind
> I'll just drop the fixes tag whilst applying.
Applied to testing with the fixes tag dropped.

Thanks,

J