Re: [PATCH v2] drm/bridge: ite-it66121: Convert to DRM HDMI Audio Helper

[Javier Martinez Canillas]

Sen Wang <sen@xxxxxx> writes:

Hello Sen,

> Convert the IT66121 HDMI bridge driver from manually registering an
> hdmi-codec platform device to using the DRM HDMI Audio Helper framework
> via DRM_BRIDGE_OP_HDMI_AUDIO instead.
>
> The previous implementation manually allocated hdmi_codec_pdata,
> registered the platform device, and implemented hdmi_codec_ops callbacks
> including get_eld. The new approach sets DRM_BRIDGE_OP_HDMI_AUDIO on the
> bridge, letting the framework handle the codec registration. This also
> resolves some non-compliance issues with the current audio implementation,
> such as HDMI audio advertising a non-functional capture stream to userspace.
>
> The audio callbacks are converted from hdmi_codec_ops signatures to
> drm_bridge_funcs hdmi_audio callbacks:
>   - it66121_audio_hw_params   -> it66121_hdmi_audio_prepare
>   - it66121_audio_startup     -> it66121_hdmi_audio_startup
>   - it66121_audio_shutdown    -> it66121_hdmi_audio_shutdown
>   - it66121_audio_mute        -> it66121_hdmi_audio_mute_stream
>
> The it66121_audio_get_eld, it66121_audio_codec_ops, and
> it66121_audio_codec_init functions are removed as the framework handles
> these responsibilities.
>
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> Signed-off-by: Sen Wang <sen@xxxxxx>
> ---

The patch looks correct to me but I'm not that familiar with the HDMI
helpers, so it would be great if either Dmitry or Maxime could take a
look to the changes before merging it.

Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat