Re: [PATCH 2/3] usb: typec: tipd: demote missing IRQ log to info for polling mode
From: Heikki Krogerus
Date: Mon May 18 2026 - 06:27:29 EST
On Wed, May 13, 2026 at 11:58:49PM +0530, Radhey Shyam Pandey wrote:
> Operating without an interrupt line and using the driver's polling path
> is valid. Log at info level instead of warning.
>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxx>
> ---
> drivers/usb/typec/tipd/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index b282366b5326..fcd56bcffab8 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -1853,7 +1853,7 @@ static int tps6598x_probe(struct i2c_client *client)
> IRQF_SHARED | IRQF_ONESHOT,
> dev_name(&client->dev), tps);
> } else {
> - dev_warn(tps->dev, "Unable to find the interrupt, switching to polling\n");
> + dev_info(tps->dev, "no IRQ specified, using polling mode\n");
If this is a valid case, then the driver should not make any noise.
Let's use deb_dbg() instead.
> INIT_DELAYED_WORK(&tps->wq_poll, tps6598x_poll_work);
> queue_delayed_work(system_power_efficient_wq, &tps->wq_poll,
> msecs_to_jiffies(POLL_INTERVAL));
thanks,
--
heikki