Re: [PATCH v2] [net-next] dibs: Improve DIBS prompts and help texts

[Alexandra Winter]

On 15.05.26 11:56, Geert Uytterhoeven wrote:
> The Kconfig prompts for the DIBS options read:
> 
>     DIBS support (DIBS) [N/m/y/?]
>       intra-OS shortcut with dibs loopback (DIBS_LO) [N/y/?]
> 
> Clarify the DIBS prompt by expanding the acronym.
> Capitalize the first character of the DIBS_LO prompt.
> While at it, join the first two lines of the DIBS help text into a real
> sentence.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> v2:
>   - Drop changing dibs to all caps, which was completely wrong for the
>     module name,
>   - Target "net-next" instead of "net".
> ---
>  drivers/dibs/Kconfig | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/dibs/Kconfig b/drivers/dibs/Kconfig
> index 5dc347b9b2350667..8f41e562210044df 100644
> --- a/drivers/dibs/Kconfig
> +++ b/drivers/dibs/Kconfig
> @@ -1,18 +1,18 @@
>  # SPDX-License-Identifier: GPL-2.0
>  config DIBS
> -	tristate "DIBS support"
> +	tristate "Direct Internal Buffer Sharing support"
>  	default n
>  	help
> -	  Direct Internal Buffer Sharing (DIBS)
> -	  A communication method that uses common physical (internal) memory
> -	  for synchronous direct access into a remote buffer.
> +	  Direct Internal Buffer Sharing (DIBS) is a communication method that
> +	  uses common physical (internal) memory for synchronous direct access
> +	  into a remote buffer.
>  
>  	  Select this option to provide the abstraction layer between
>  	  dibs devices and dibs clients like the SMC protocol.
>  	  The module name is dibs.
>  
>  config DIBS_LO
> -	bool "intra-OS shortcut with dibs loopback"
> +	bool "Intra-OS shortcut with dibs loopback"
>  	depends on DIBS
>  	default n
>  	help


Thank you Geert

Reviewed-by: Alexandra Winter <wintera@xxxxxxxxxxxxx>