Re: [PATCH v2 5/7] iio: core: Add IIO_COVERAGE_PERCENT channel type

[Liviu Stan]

On Sat, 16 May 2026 17:58:14 +0100 Jonathan Cameron <jic23@xxxxxxxxxx> wrote:

> On Thu, 14 May 2026 17:46:52 +0300
> Liviu Stan <liviu.stan@xxxxxxxxxx> wrote:
> 
> > Add a new channel type for sensors that report fractional coverage as
> > a percentage. The first user is the ADT7604 leak detector, where the
> > value represents the portion of the sensing element that is wetted.
> > 
> > Signed-off-by: Liviu Stan <liviu.stan@xxxxxxxxxx>
> Few things from sashiko that you should address.
> 
> One I want to talk more about...
> 
> > ---
> > Changes in v2:
> > - New patch.
> > 
> >  Documentation/ABI/testing/sysfs-bus-iio | 10 ++++++++++
> >  drivers/iio/industrialio-core.c         |  1 +
> >  include/uapi/linux/iio/types.h          |  1 +
> >  tools/iio/iio_event_monitor.c           |  1 +
> >  4 files changed, 13 insertions(+)
> > 
> > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> > index 925a33fd309a..0570e8b8f5e5 100644
> > --- a/Documentation/ABI/testing/sysfs-bus-iio
> > +++ b/Documentation/ABI/testing/sysfs-bus-iio
> > @@ -1980,6 +1980,16 @@ Description:
> >  		Raw (unscaled no offset etc.) resistance reading.
> >  		Units after application of scale and offset are ohms.
> >  
> > +What:		/sys/bus/iio/devices/iio:deviceX/in_coveragepercentX_raw
> 
> The bot raises a valid concern about having the unit in the _raw attribute name.
> If there is a scale (which incidentally probably needs adding to the ABI - as
> _raw on its own is a bit meaningless) then it only becomes percent after
> that is applied.
> 
> Perhaps
> in_coverageX_raw is the way to go?
> 

This makes sense, I will modify in v3.

Thanks,
Liviu