Re: [PATCH v2 1/7] iio: temperature: ltc2983: Fix macro parenthesization and rename

[Liviu Stan]

On Sat, 16 May 2026 17:43:18 +0100 Jonathan Cameron <jic23@xxxxxxxxxx> wrote:

> On Thu, 14 May 2026 17:46:48 +0300
> Liviu Stan <liviu.stan@xxxxxxxxxx> wrote:
> 
> > Wrap the 'chan' parameter in LTC2983_CHAN_START_ADDR() and
> > LTC2983_CHAN_RES_ADDR() with parentheses to prevent potential
> > macro argument expansion issues. Also rename LTC2983_CHAN_START_ADDR
> > to LTC2983_CHAN_ASSIGN_ADDR and LTC2983_CHAN_RES_ADDR to
> > LTC2983_RESULT_ADDR, to better reflect the datasheet names and avoid
> > them being confused as related.
> > 
> > Fixes: f110f3188e5639c81c457b2b831d40dfe3891bdb ("iio: temperature: Add support for LTC2983")
> Firstly 12 chars of the hash is enough.
> Secondly why a fix at all?
> 
> Looks like a readability improvement but not something we'd backport.
> 

I understand, I will change in v3.

> Also as Sashiko points out you need to mention the additional parameter.
>  https://sashiko.dev/#/patchset/20260514144712.64374-1-liviu.stan%40analog.com
> 
> Also, build your series one patch at a time.  This looks like it won't build.
> Jonathan
> 

Yes, I mistakenly placed that change in patch 7. I apologize for that. I will
change in v3.

Thanks,
Liviu