Re: [PATCH v3] nfc: nxp-nci: i2c: use rising-edge IRQ on ACPI systems
From: Bartosz Golaszewski
Date: Mon May 18 2026 - 04:38:11 EST
On Sat, 16 May 2026 13:55:18 +0200, Carl Lee via B4 Relay
<devnull+carl.lee.amd.com@xxxxxxxxxx> said:
> From: Carl Lee <carl.lee@xxxxxxx>
>
> Some ACPI-based platforms report incorrect IRQ trigger types (e.g.
> IRQF_TRIGGER_HIGH), which can lead to interrupt storms.
>
> Use the historically working rising-edge trigger on ACPI systems to
> avoid this regression.
>
> Device Tree-based systems continue to use the firmware-provided
> trigger type.
>
> Signed-off-by: Carl Lee <carl.lee@xxxxxxx>
> ---
> Some ACPI-based platforms report incorrect IRQ trigger types,
> which can lead to interrupt storms.
>
> Use rising-edge IRQ on ACPI systems to avoid this regression,
> while keeping firmware-provided trigger types on non-ACPI systems.
>
> Cc: netdev@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: krzk@xxxxxxxxxx
> Cc: carl.lee@xxxxxxx
> Cc: peter.shen@xxxxxxx
> Cc: colin.huang2@xxxxxxx
> Cc: kuba@xxxxxxxxxx
> Cc: david@xxxxxxx
> Cc: luca.stefani.ge1@xxxxxxxxx
> Cc: brgl@xxxxxxxxxx
> Cc: mpearson@xxxxxxxxx
> ---
LGTM!
Tested-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
Maybe:
Fixes: 57be33f85e36 ("nfc: nxp-nci: remove interrupt trigger type")
Cc: stable@xxxxxxxxxxxxxxx # v6.19.y
?
Bart