Re: [PATCH 05/12] gpiolib: acpi: Declare shared structures in gpiolib-acpi.h

From: Andy Shevchenko

Date: Mon May 18 2026 - 04:21:39 EST


On Mon, May 18, 2026 at 09:53:50AM +0200, Marco Scardovi (scardracs) wrote:

...

> +#include <linux/acpi.h>
> #include <linux/err.h>
> -#include <linux/types.h>
> -

> #include <linux/gpio/consumer.h>

This header was specifically made into a separate group.

> +#include <linux/interrupt.h>

> +#include <linux/list.h>

We don't include headers that are not being used. Follow IWYU.

> +#include <linux/mutex.h>
> +#include <linux/types.h>

--
With Best Regards,
Andy Shevchenko