Re: [PATCH 01/13] verification/rvgen: Switch LTL parser to Lark

[Nam Cao]

Wander Lairson Costa <wander@xxxxxxxxxx> writes:
>> +VARIABLE: /[A-Z_0-9]+/
>
> Is it ok to start variable names with a number? (unless I am reading the
> regex wrong).

Thanks for pointing that out. Let me switch to Lark's built-in CNAME.

>> +    def LITERAL(self, args):
>> +        return ASTNode(Variable(args))
>
> shouldn't this be `return ASTNode(Literal(args) == "true")`?

Yeah that's broken, should be
    return ASTNode(Literal(args == "true"))

Nam