RE: [PATCH v3] wifi: rtw88: usb: fix memory leaks on USB write failures

[Ping-Ke Shih]

> @@ -456,7 +457,13 @@ static bool rtw_usb_tx_agg_skb(struct rtw_usb *rtwusb, struct sk_buff_head *list
>         tx_desc = (struct rtw_tx_desc *)skb_head->data;
>         qsel = le32_get_bits(tx_desc->w1, RTW_TX_DESC_W1_QSEL);
> 
> -       rtw_usb_write_port(rtwdev, qsel, skb_head, rtw_usb_write_port_tx_complete, txcb);
> +       ret = rtw_usb_write_port(rtwdev, qsel, skb_head,
> +                                rtw_usb_write_port_tx_complete, txcb);

ERROR: code indent should use tabs where possible
#54: FILE: drivers/net/wireless/realtek/rtw88/usb.c:461:
+^I^I^I         rtw_usb_write_port_tx_complete, txcb);$

CHECK: Alignment should match open parenthesis
#54: FILE: drivers/net/wireless/realtek/rtw88/usb.c:461:
+	ret = rtw_usb_write_port(rtwdev, qsel, skb_head,
+			         rtw_usb_write_port_tx_complete, txcb);

Please correct them and resend v4. (You can take my acked-by in v3)

> +       if (ret) {
> +               ieee80211_purge_tx_queue(rtwdev->hw, &txcb->tx_ack_queue);
> +               kfree(txcb);
> +               return false;
> +       }
> 
>         return true;
>  }