Re: Re: [PATCH v5 3/3] reset: eswin: Add eic7700 HSP reset driver

[Xuyang Dong]

> 
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Missing `#include <linux/module.h>` for module macros.
> --
> 
> commit 08281f0596a764e191cbecfd9dc12b0b51f6730f
> Author: Xuyang Dong <dongxuyang@xxxxxxxxxxxxxxxxxx>
> 
> reset: eswin: Add eic7700 HSP reset driver
> 
> This commit adds an auxiliary driver to support the ESWIN EIC7700 high-speed
> peripherals system. The reset controller is created using the auxiliary device
> framework.
> 
> > diff --git a/drivers/reset/reset-eic7700-hsp.c b/drivers/reset/reset-eic7700-hsp.c
> > new file mode 100644
> > index 0000000000000..bdd4f5e3d7a76
> > --- /dev/null
> > +++ b/drivers/reset/reset-eic7700-hsp.c
> > @@ -0,0 +1,112 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright 2026, Beijing ESWIN Computing Technology Co., Ltd..
> > + * All rights reserved.
> > + *
> > + * ESWIN EIC7700 HSP Reset Driver
> > + *
> > + * Authors: Xuyang Dong <dongxuyang@xxxxxxxxxxxxxxxxxx>
> > + */
> > +
> > +#include <linux/auxiliary_bus.h>
> > +#include <linux/device.h>
> > +#include <linux/regmap.h>
> > +#include <linux/reset-controller.h>
> 
> This isn't a bug, but should this file explicitly include <linux/module.h>?
> 

Hi Sashiko,

<linux/module.h> will be included in the next version.

Best regards,
Xuyang Dong

> The code relies on module-specific macros such as THIS_MODULE,
> MODULE_DEVICE_TABLE, MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION
> later in the file. Relying on an implicit include could lead to unexpected
> build failures if header dependencies change in the future.
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260514114212.903-1-dongxuyang@xxxxxxxxxxxxxxxxxx?part=3