Re: [PATCH] net: octeon: fix carrier state, null guard, and modernize phy ioctl

[Dan Carpenter]

On Sun, May 17, 2026 at 09:19:55AM -0500, shayderrr wrote:
> From: Pranav Bajjuri <darknessshayder@xxxxxxxxx>
> 
> Add netif_carrier_off() to cvm_oct_common_stop(),

Why?  Shouldn't this be in it's own patch?  Do we need a Fixes tag?

> guard
> cvm_oct_adjust_link() against null phydev,

Can this really happen or is this AI advice?  Shouldn't this be in
it's own patch?  Do we need a Fixes tag?  You have added a
WARN_ON() which basically means reboot the kernel on most systems
so it's discouraged as much as possible.

> replace open-coded
> ioctl checks with phy_do_ioctl_running(),

Put this in its own patch.

> and zero priv->link_info
> on stop alongside last_link.

Why?  Shouldn't this be in it's own patch?  Do we need a Fixes tag?

regards,
dan carpenter