Re: [PATCH] net: octeon: fix carrier state, null guard, and modernize phy ioctl

[Greg KH]

On Sun, May 17, 2026 at 11:44:20AM -0500, shxyder wrote:
> Hi Greg,
> 
> Thank you for the feedback. I will split this into separate patches, one
> change per patch, and resubmit as a series.
> 
> Regarding testing: I do not have access to OCTEON hardware, so I have not
> been able to runtime test this. The changes are straightforward — adding a
> missing netif_carrier_off(), a null guard, replacing phy_mii_ioctl() with
> phy_do_ioctl_running(), and zeroing a cached field on stop. I should have
> mentioned this upfront and I apologize for not doing so.

It also looks like you did not test-build your patches, which is
generally always a requirement :)

thanks,

greg k-h