Re: [PATCH] ARM: PCI: expand single-line pci_common_init() wrapper function

From: Ethan Nelson-Moore

Date: Mon May 18 2026 - 00:21:06 EST


Hi, Andrew,

On Sun, May 17, 2026 at 8:42 PM Andrew Lunn <andrew@xxxxxxx> wrote:
> Nobody seems to call pci_common_init_dev() without passing NULL. So i
> think it makes more sense to rename pci_common_init_dev() to
> pci_common_init() and drop struct device *parent parameter. You then
> only need to change pci.h and bios32.c.

I considered that, but decided against it because it would prevent the
code from easily being updated to pass a parent parameter in the
future. However, given the age of the affected platforms, that is
unlikely to happen, so your approach might make more sense. What do
you think?

Ethan