Re: [PATCH] iio: pressure: rohm-bm1390: notify trigger on all error paths

From: Stepan Ionichev

Date: Sun May 17 2026 - 13:18:50 EST


On Sun, May 17, 2026, David Lechner wrote:
> IRQ_NONE means that the interrupt wasn't handled, so it won't be cleared
> and the handler will likely just run again immediately. So it probably
> isn't the right thing to be returning in the first place.

Right -- though here it is called via handle_nested_irq() from the
threaded pollfunc, so the return value does not feed the IRQ
controller and the immediate re-fire concern is moot in practice.
But the IRQ_NONE choice is still odd.

Matti, do you want a v2 that always returns IRQ_HANDLED on the
error paths instead, or keep the current shape and just fix the
missing notify_done()?

Stepan