Re: [PATCH v3 2/5] iio: dac: ad5504: sort headers alphabetically
From: Jonathan Cameron
Date: Sun May 17 2026 - 10:31:53 EST
On Sat, 9 May 2026 15:20:40 +0100
Taha Ed-Dafili <0rayn.dev@xxxxxxxxx> wrote:
> Rearrange the include headers in alphabetical order to follow the
> standard kernel coding style. This is a preparatory cleanup with
> no functional changes.
>
> Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>
> Signed-off-by: Taha Ed-Dafili <0rayn.dev@xxxxxxxxx>
I'm going to pick what I can from this series now - just to
reduce what we see in v4.
Applied this one.
> ---
> drivers/iio/dac/ad5504.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c
> index 355bcb6a8ba0..03ce37e2c616 100644
> --- a/drivers/iio/dac/ad5504.c
> +++ b/drivers/iio/dac/ad5504.c
> @@ -5,21 +5,21 @@
> * Copyright 2011 Analog Devices Inc.
> */
>
> -#include <linux/interrupt.h>
> -#include <linux/fs.h>
> +#include <linux/bitops.h>
> #include <linux/device.h>
> +#include <linux/fs.h>
> +#include <linux/interrupt.h>
> #include <linux/kernel.h>
> -#include <linux/spi/spi.h>
> +#include <linux/module.h>
> +#include <linux/regulator/consumer.h>
> #include <linux/slab.h>
> +#include <linux/spi/spi.h>
> #include <linux/sysfs.h>
> -#include <linux/regulator/consumer.h>
> -#include <linux/module.h>
> -#include <linux/bitops.h>
>
> +#include <linux/iio/dac/ad5504.h>
> +#include <linux/iio/events.h>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> -#include <linux/iio/events.h>
> -#include <linux/iio/dac/ad5504.h>
>
> #define AD5504_RES_MASK GENMASK(11, 0)
> #define AD5504_CMD_READ BIT(15)