Re: [PATCH v13 07/12] iio: test: iio-test-format: add test case for decimal format
From: Jonathan Cameron
Date: Sun May 17 2026 - 10:03:56 EST
On Sun, 17 May 2026 10:14:02 +0100
Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@xxxxxxxxxx> wrote:
> From: Rodrigo Alencar <rodrigo.alencar@xxxxxxxxxx>
>
> Add iio_test_iio_format_value_decimal_64() kunit test case for decimal
> value formatting, exploring different scales types. Also, the same
> iio_val_s64_array_populate() macro used to populate local array is used in
> iio_test_iio_format_value_integer_64().
Sashiko calls out that this needs an update. Doesn't seem to use iio_val_s64_array_populate()
No other comment. Context left so anyone reading this can check for themselves
>
> Signed-off-by: Rodrigo Alencar <rodrigo.alencar@xxxxxxxxxx>
> ---
> drivers/iio/test/iio-test-format.c | 97 +++++++++++++++++++++++++++++---------
> 1 file changed, 75 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/iio/test/iio-test-format.c b/drivers/iio/test/iio-test-format.c
> index 872dd8582003..1920dee3bfb0 100644
> --- a/drivers/iio/test/iio-test-format.c
> +++ b/drivers/iio/test/iio-test-format.c
> @@ -200,56 +200,108 @@ static void iio_test_iio_format_value_multiple(struct kunit *test)
> static void iio_test_iio_format_value_integer_64(struct kunit *test)
> {
> int values[2];
> - s64 value;
> char *buf;
> int ret;
>
> buf = kunit_kmalloc(test, PAGE_SIZE, GFP_KERNEL);
> KUNIT_ASSERT_NOT_ERR_OR_NULL(test, buf);
>
> - value = 24;
> - values[0] = lower_32_bits(value);
> - values[1] = upper_32_bits(value);
> + iio_val_s64_to_s32s(24, values);
> ret = iio_format_value(buf, IIO_VAL_INT_64, ARRAY_SIZE(values), values);
> IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "24\n");
>
> - value = -24;
> - values[0] = lower_32_bits(value);
> - values[1] = upper_32_bits(value);
> + iio_val_s64_to_s32s(-24, values);
> ret = iio_format_value(buf, IIO_VAL_INT_64, ARRAY_SIZE(values), values);
> IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "-24\n");
>
> - value = 0;
> - values[0] = lower_32_bits(value);
> - values[1] = upper_32_bits(value);
> + iio_val_s64_to_s32s(0, values);
> ret = iio_format_value(buf, IIO_VAL_INT_64, ARRAY_SIZE(values), values);
> IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "0\n");
>
> - value = UINT_MAX;
> - values[0] = lower_32_bits(value);
> - values[1] = upper_32_bits(value);
> + iio_val_s64_to_s32s(UINT_MAX, values);
> ret = iio_format_value(buf, IIO_VAL_INT_64, ARRAY_SIZE(values), values);
> IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "4294967295\n");
>
> - value = -((s64)UINT_MAX);
> - values[0] = lower_32_bits(value);
> - values[1] = upper_32_bits(value);
> + iio_val_s64_to_s32s(-((s64)UINT_MAX), values);
> ret = iio_format_value(buf, IIO_VAL_INT_64, ARRAY_SIZE(values), values);
> IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "-4294967295\n");
>
> - value = LLONG_MAX;
> - values[0] = lower_32_bits(value);
> - values[1] = upper_32_bits(value);
> + iio_val_s64_to_s32s(LLONG_MAX, values);
> ret = iio_format_value(buf, IIO_VAL_INT_64, ARRAY_SIZE(values), values);
> IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "9223372036854775807\n");
>
> - value = LLONG_MIN;
> - values[0] = lower_32_bits(value);
> - values[1] = upper_32_bits(value);
> + iio_val_s64_to_s32s(LLONG_MIN, values);
> ret = iio_format_value(buf, IIO_VAL_INT_64, ARRAY_SIZE(values), values);
> IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "-9223372036854775808\n");
> }
>
> +static void iio_test_iio_format_value_decimal_64(struct kunit *test)
> +{
> + int values[2];
> + char *buf;
> + int ret;
> +
> + buf = kunit_kmalloc(test, PAGE_SIZE, GFP_KERNEL);
> + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, buf);
> +
> + /* DECIMAL64_MILLI: positive >= 1, value 1.234 */
> + iio_val_s64_to_s32s(1234, values);
> + ret = iio_format_value(buf, IIO_VAL_DECIMAL64_MILLI, ARRAY_SIZE(values), values);
> + IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "1.234\n");
> +
> + /* DECIMAL64_MICRO: positive >= 1, value 3.141592 */
> + iio_val_s64_to_s32s(3141592, values);
> + ret = iio_format_value(buf, IIO_VAL_DECIMAL64_MICRO, ARRAY_SIZE(values), values);
> + IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "3.141592\n");
> +
> + /* DECIMAL64_MILLI: positive < 1, value 0.042 */
> + iio_val_s64_to_s32s(42, values);
> + ret = iio_format_value(buf, IIO_VAL_DECIMAL64_MILLI, ARRAY_SIZE(values), values);
> + IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "0.042\n");
> +
> + /* DECIMAL64_MILLI: negative <= -1, value -1.234 */
> + iio_val_s64_to_s32s(-1234, values);
> + ret = iio_format_value(buf, IIO_VAL_DECIMAL64_MILLI, ARRAY_SIZE(values), values);
> + IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "-1.234\n");
> +
> + /* DECIMAL64_MILLI: negative > -1, value -0.123 */
> + iio_val_s64_to_s32s(-123, values);
> + ret = iio_format_value(buf, IIO_VAL_DECIMAL64_MILLI, ARRAY_SIZE(values), values);
> + IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "-0.123\n");
> +
> + /* DECIMAL64_MILLI: zero */
> + iio_val_s64_to_s32s(0, values);
> + ret = iio_format_value(buf, IIO_VAL_DECIMAL64_MILLI, ARRAY_SIZE(values), values);
> + IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "0.000\n");
> +
> + /* DECIMAL64_NANO: value 1.000000001 */
> + iio_val_s64_to_s32s(1000000001, values);
> + ret = iio_format_value(buf, IIO_VAL_DECIMAL64_NANO, ARRAY_SIZE(values), values);
> + IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "1.000000001\n");
> +
> + /* DECIMAL64_MICRO: large value using upper 32 bits */
> + iio_val_s64_to_s32s(5000000000000042LL, values);
> + ret = iio_format_value(buf, IIO_VAL_DECIMAL64_MICRO, ARRAY_SIZE(values), values);
> + IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "5000000000.000042\n");
> +
> + /* limits */
> + iio_val_s64_to_s32s(LLONG_MAX, values);
> + ret = iio_format_value(buf, IIO_VAL_DECIMAL64_PICO, ARRAY_SIZE(values), values);
> + IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "9223372.036854775807\n");
> + ret = iio_format_value(buf, IIO_VAL_DECIMAL64_NANO, ARRAY_SIZE(values), values);
> + IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "9223372036.854775807\n");
> + ret = iio_format_value(buf, IIO_VAL_DECIMAL64_MICRO, ARRAY_SIZE(values), values);
> + IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "9223372036854.775807\n");
> +
> + iio_val_s64_to_s32s(LLONG_MIN, values);
> + ret = iio_format_value(buf, IIO_VAL_DECIMAL64_PICO, ARRAY_SIZE(values), values);
> + IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "-9223372.036854775808\n");
> + ret = iio_format_value(buf, IIO_VAL_DECIMAL64_NANO, ARRAY_SIZE(values), values);
> + IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "-9223372036.854775808\n");
> + ret = iio_format_value(buf, IIO_VAL_DECIMAL64_MICRO, ARRAY_SIZE(values), values);
> + IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "-9223372036854.775808\n");
> +}
> +
> static struct kunit_case iio_format_test_cases[] = {
> KUNIT_CASE(iio_test_iio_format_value_integer),
> KUNIT_CASE(iio_test_iio_format_value_fixedpoint),
> @@ -257,6 +309,7 @@ static struct kunit_case iio_format_test_cases[] = {
> KUNIT_CASE(iio_test_iio_format_value_fractional_log2),
> KUNIT_CASE(iio_test_iio_format_value_multiple),
> KUNIT_CASE(iio_test_iio_format_value_integer_64),
> + KUNIT_CASE(iio_test_iio_format_value_decimal_64),
> { }
> };
>
>