Re: [PATCH v2 09/10] iio: light: opt3001: switch driver to managed resources

[Jonathan Cameron]

On Sat, 16 May 2026 19:04:56 +0200
Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:

> On Sat, 16 May 2026 at 14:10, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> >
> > On Tue, 12 May 2026 15:26:00 +0100
> > Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> >  
> > > On Tue, 12 May 2026 12:57:29 +0200
> > > Joshua Crofts via B4 Relay <devnull+joshua.crofts1.gmail.com@xxxxxxxxxx> wrote:
> > >  
> > > > From: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
> > > >
> > > > Move the driver to use devm_* functions to automate resource
> > > > management and simplify error handling. This also allows removal
> > > > of the opt3001_remove() function.
> > > >
> > > > Signed-off-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>  
> > > Some trivial stuff inline.  I'll probably wait for sashiko to catch up with
> > > it's backlog and get to this one.  If nothing comes up there or in other reviews
> > > I'm fine tweaking the stuff below whilst applying the series.
> > >  
> > Sashiko did come back with a lifetime issue.
> >
> > I think it's a false positive as there aren't any workqueues or similar
> > that might still be active. IRQs will long have been cleaned up before
> > the mutex_destroy() occurs.  
> 
> I would agree this is a false positive since the request_threaded_irq was
> moved to use the devm_ counterpart in this patch.
> 
> On an unrelated note, I also have a first version of a new driver I'm working
> on, is it okay to send or is the workload too big?
> 
Fine to send new drivers. Just try to ensure you don't have too many patches
under review at one time.  Keeps things fair with so many contributors.

Exactly how many is too many is a bit subjective and depends on the complexity
/ type of patch but never more than 20 unless there is a mass refactor in
there (1 line patch stuff).

Jonathan