Re: [PATCH net-next v2 1/2] dpll: add DPLL_PIN_TYPE_INT_NCO pin type

[Jiri Pirko]

Sat, May 16, 2026 at 07:57:43PM +0200, ivecera@xxxxxxxxxx wrote:
>Add DPLL_PIN_TYPE_INT_NCO pin type for virtual pins representing
>the NCO mode of a DPLL. When connected as a DPLL input, the DPLL
>enters NCO mode where the output frequency is adjusted by the host
>via the PTP clock interface.
>
>Update the fractional-frequency-offset and fractional-frequency-
>offset-ppt attribute documentation to note that for INT_NCO pins
>these attributes represent the DPLL's current output frequency
>offset from its nominal frequency.
>
>---
>v2:
>  - Clarify int-nco pin type documentation to describe frequency
>    control via the PTP clock interface instead of generic "controlled
>    by the host".
>  - Tighten FFO attribute documentation for INT_NCO pins to describe
>    the DPLL's output frequency offset from nominal frequency.
>  - Mention both fractional-frequency-offset (PPM) and
>    fractional-frequency-offset-ppt attributes in the commit message.
>
>Signed-off-by: Ivan Vecera <ivecera@xxxxxxxxxx>

Like it!

Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxx>