Re: [PATCH 1/3] media: dt-bindings: qcom: add JPEG encoder binding
From: Krzysztof Kozlowski
Date: Sat May 16 2026 - 16:16:52 EST
On 16/05/2026 17:51, Bryan O'Donoghue wrote:
> On 15/05/2026 12:46, Atanas Filipov wrote:
>> +properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - qcom,sc7180-jenc
>> + - qcom,sm8250-jenc
>> + - qcom,sm7325-jenc
>> + - qcom,sc7280-jenc
>> + - qcom,qcm6490-jenc
>> + - qcom,sm8550-jenc
>
> Per my previous feedback.
>
> Please only list the items you are also providing in the DTS to be verified.
>
> For example if this driver works on sm8250 there should be an enabling
> patch for the DTS to that effect so that it can be verified.
>
> Right now I believe all you are asserting in this way is qcm6490, so I
> advise very strongly to either add the missing elements or just drop
> what's not shown to be supported in your submission.
Bryan, before you waste more time here - you missed announcement that
this should have never been posted.
Best regards,
Krzysztof