Re: [PATCH] iio: trigger: iio-trig-interrupt: use devm_* helpers
From: Jonathan Cameron
Date: Sat May 16 2026 - 07:25:03 EST
On Wed, 13 May 2026 13:33:42 +0500
Stepan Ionichev <sozdayvek@xxxxxxxxx> wrote:
> On Mon, May 11, 2026 at 19:56, Jonathan Cameron wrote:
> > Silly question for you - how does this driver actually bind on a
> > modern platform? That is - how do we get one of these?
>
> It does not, as far as I can see.
>
> Grep across the mainline tree:
>
> - The string "iio_interrupt_trigger" appears only in the driver itself
> (drivers/iio/trigger/iio-trig-interrupt.c:101 — the .driver.name).
> - No .of_match_table and no .id_table on the driver.
> - No platform_device_register*() call anywhere in arch/, drivers/ or
> board files that would create a device named "iio_interrupt_trigger".
> - No Documentation/devicetree/bindings/ entry.
>
> So the only way to instantiate it on a current kernel is an explicit
> out-of-tree platform_device_register("iio_interrupt_trigger", ...), and
> nothing in mainline does that.
>
> Given that, please drop v1 and v2 of this patch. The cleanup-for-its-
> own-sake is not worth the parent / sysfs-hierarchy change Andy flagged
> when there are no in-tree users to validate it against.
>
> If at some point a user appears in mainline (DT binding, ACPI hookup
> or a board file), the devm_* conversion can come along with that work.
>
> Sorry for the noise.
No problem! You got us looking at it.
So wider question for anyone reading - do we actually want to keep
this driver? Meh, to catch peoples attention better than in this
thread I'll propose a patch dropping it and see what responses we get.
Jonathan
>
> Stepan