Re: [PATCH] iio: adc: ad7192: fix GPOCON register access annotation
From: Jonathan Cameron
Date: Sat May 16 2026 - 06:56:17 EST
On Wed, 13 May 2026 16:35:30 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
> On Wed, May 13, 2026 at 03:13:32PM +0500, Stepan Ionichev wrote:
> > The comment next to AD7192_REG_GPOCON marks the register as RO,
> > but the AD7192 datasheet (Rev. A, page 24, GPOCON REGISTER) says:
> > "The GPOCON register is an 8-bit register from which data can be
> > read or to which data can be written."
> >
> > The driver itself uses ad_sd_write_reg() against this register in
> > ad7192_show_scale() / write paths to control the bridge power-down
> > switch and digital outputs, which matches the RW datasheet
> > description. Update the comment to RW so it does not mislead
> > future readers.
>
> Makes sense,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
>
Applied to the testing branch of iio.git.
thanks,
Jonathan