Re: [PATCH 6.18 000/188] 6.18.32-rc1 review

[Greg KH]

On Sat, May 16, 2026 at 01:13:04AM +0800, Wentao Guan wrote:
> Build failed, you can drop the commit to build ok:
> git revert 0253904dd601b15da2983297d64c106a393b3aa3.
> Revert "sched_ext: Use HK_TYPE_DOMAIN_BOOT to detect isolcpus= domain isolation"
> 
> Tested-by: Wentao Guan <guanwentao@xxxxxxxxxxxxx>
> 
> BRs
> Wentao Guan
> 
> defconfigs:
> https://gist.github.com/opsiff/a840ae9e3d6857f5b7bacb9cdc49f8e9
> 
> Log:
> kernel/sched/ext.c: In function ‘scx_enable’:
> kernel/sched/ext.c:4924:34: error: ‘HK_TYPE_DOMAIN_BOOT’ undeclared (first use in this function); did you mean ‘HK_TYPE_DOMAIN’?
>  4924 |         if (housekeeping_enabled(HK_TYPE_DOMAIN_BOOT)) {
>       |                                  ^~~~~~~~~~~~~~~~~~~
>       |                                  HK_TYPE_DOMAIN
> kernel/sched/ext.c:4924:34: note: each undeclared identifier is reported only once for each function it appears in
>   CC [M]  crypto/algif_hash.o
> 
> commit 4fca0e550d506e1c95504c2d9247bc92bf621bf6
> Author: Frederic Weisbecker <frederic@xxxxxxxxxx>
> Date:   Mon May 26 13:06:21 2025 +0200
> 
>     sched/isolation: Save boot defined domain flags
> 
>     HK_TYPE_DOMAIN will soon integrate not only boot defined isolcpus= CPUs
>     but also cpuset isolated partitions.
> 
>     Housekeeping still needs a way to record what was initially passed
>     to isolcpus= in order to keep these CPUs isolated after a cpuset
>     isolated partition is modified or destroyed while containing some of
>     them.
> 
>     Create a new HK_TYPE_DOMAIN_BOOT to keep track of those.
> 
>     Signed-off-by: Frederic Weisbecker <frederic@xxxxxxxxxx>
>     Reviewed-by: Phil Auld <pauld@xxxxxxxxxx>
>     Reviewed-by: Waiman Long <longman@xxxxxxxxxx>
>     Cc: Ingo Molnar <mingo@xxxxxxxxxx>
>     Cc: Marco Crivellari <marco.crivellari@xxxxxxxx>
>     Cc: Michal Hocko <mhocko@xxxxxxxx>
>     Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>     Cc: Tejun Heo <tj@xxxxxxxxxx>
>     Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>     Cc: Vlastimil Babka <vbabka@xxxxxxx>
>     Cc: Waiman Long <longman@xxxxxxxxxx>

Thanks, will go and drop this commit now.

greg k-h