Re: [PATCH v2 1/2] dt-bindings: sound: simple-card: add system-clock-id property

[Krzysztof Kozlowski]

On Fri, May 15, 2026 at 11:13:57AM -0500, Sen Wang wrote:
> Document the new optional "system-clock-id" u32 property for cpu/codec
> sub-nodes in simple-audio-card and audio-graph-card.
> 
> The property maps directly to the clk_id argument of
> snd_soc_dai_set_sysclk(). When absent the existing default of 0 is

That's driver argument in bindings. Poor way to start discussion. Please
describe the hardware instead.


> used, so no existing DT is affected. CPU and codec sub-nodes are
> parsed independently; each side may carry a different value to select
> different clock sources on the two DAIs within the same dai-link.

Again, nothing about the hardware here.

> 
> Signed-off-by: Sen Wang <sen@xxxxxx>
> ---
> changes in V2:
>   - Newly added (V1 is RFC)
> 
> diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> index d1cbfc5edd3a..8094a76b9b4a 100644
> --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> @@ -67,6 +67,8 @@ definitions:
>          $ref: simple-card.yaml#/definitions/system-clock-direction-out
>        system-clock-fixed:
>          $ref: simple-card.yaml#/definitions/system-clock-fixed
> +      system-clock-id:
> +        $ref: simple-card.yaml#/definitions/system-clock-id
>  
>        dai-format:
>          description: audio format.
> diff --git a/Documentation/devicetree/bindings/sound/simple-card.yaml b/Documentation/devicetree/bindings/sound/simple-card.yaml
> index a14716b2732f..47a02d340d5e 100644
> --- a/Documentation/devicetree/bindings/sound/simple-card.yaml
> +++ b/Documentation/devicetree/bindings/sound/simple-card.yaml
> @@ -49,6 +49,14 @@ definitions:
>        single fixed sampling rate.
>      $ref: /schemas/types.yaml#/definitions/flag
>  
> +  system-clock-id:
> +    description:
> +      Selects which system clock to configure via set_sysclk(). Corresponds
> +      to the clk_id argument of snd_soc_dai_set_sysclk(). When absent the

So now driver APIs are part of binding :/. No.

You should have built on top or use previous discussion instead of
making new mistakes:
https://lore.kernel.org/linux-devicetree/20221022162742.21671-2-aidanmacdonald.0x0@xxxxxxxxx/

Best regards,
Krzysztof