Re: [PATCH] platform/x86: ideapad-laptop: remap "Star with S" key to KEY_DASHBOARD

[Borys]

Hi,

Any chance you've had a look at my response below?

Best regards,
Borys

Op do 23 apr 2026 om 09:59 schreef Borys <turkoborys@xxxxxxxxx>:
>
> Hi Mark,
>
> Thanks for the detailed feedback and for testing this on your
> ThinkPad. I’ve done some further testing on the IdeaPad Gaming 3
> (Cinnamon) to address your points and cross-referenced several IdeaPad
> manuals.
>
> On this specific hardware, I found that KEY_FAVORITES currently
> results in no action at all. It acts as a dead key in the desktop
> environment, so the risk of a regression for existing users seems
> minimal compared to the benefit of making the key functional.
>
> While the ThinkPad intent might be more flexible, the IdeaPad manuals
> (for the Gaming and 5 series, for example) specifically state the key
> is intended to "Open an app" or "Open Lenovo Vantage/PC Manager." I
> tested KEY_BOOKMARKS as you suggested, but found that browsers like
> Firefox "hijack" this key to open a sidebar, which prevents the user
> from mapping it to a system tool as the manual intends. Additionally,
> in my environment, the system labels this key as "Favorites," which
> might be confusing for a "PC Manager" launcher.
>
> In my testing, KEY_CONFIG seems to avoid these conflicts. The system
> identifies it as "Tools," which is a perfect semantic match for the
> Vantage tools mentioned in the documentation. It isn't intercepted by
> browsers and remains fully mappable by the user. Using a neutral key
> like KEY_PROG4 would also achieve this same goal of giving the user
> full control without default interference.
>
> I’m curious to hear your thoughts on these findings and how we can
> best align the driver with the "user-defined" intent described in the
> manuals.
>
> Best regards,
>
> Borys